pvary commented on a change in pull request #2586:
URL: https://github.com/apache/hive/pull/2586#discussion_r694672513
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
##########
@@ -720,13 +750,54 @@ public SchemaEvolution
createSchemaEvolution(TypeDescription fileSchema) {
readerSchema, readerLogicalColumnIds);
Reader.Options options = new Reader.Options(jobConf)
.include(readerIncludes).includeAcidColumns(includeAcidColumns);
- return new SchemaEvolution(fileSchema, readerSchema, options);
+ evolution = new SchemaEvolution(fileSchema, readerSchema, options);
+
+ generateLogicalOrderedColumnIds();
+ return evolution;
+ }
+
+ /**
+ * LLAP IO always returns the column vectors in the order as they are seen
in the file.
+ * To support logical column reordering, we need to do a matching between
file and read schemas.
+ * (this only supports one level of schema reordering, not within complex
types, also not supported for ORC ACID)
+ */
+ private void generateLogicalOrderedColumnIds() {
Review comment:
Maybe some debug level logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
