szlta commented on a change in pull request #2586:
URL: https://github.com/apache/hive/pull/2586#discussion_r700182811
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -417,15 +419,21 @@ public OrcTail getOrcTailFromCache(Path path,
Configuration jobConf, CacheTag ta
}
@Override
- public RecordReader<NullWritable, VectorizedRowBatch>
llapVectorizedOrcReaderForPath(Object fileKey, Path path, CacheTag tag,
List<Integer> tableIncludedCols,
- JobConf conf, long offset, long length) throws IOException {
+ public RecordReader<NullWritable, VectorizedRowBatch>
llapVectorizedOrcReaderForPath(Object fileKey, Path path,
+ CacheTag tag, List<Integer> tableIncludedCols, JobConf conf, long
offset, long length, Reporter reporter)
+ throws IOException {
- OrcTail tail = getOrcTailFromCache(path, conf, tag, fileKey);
+ OrcTail tail = null;
+ if (tag != null) {
Review comment:
- getOrcTailFromCache should always be called with a non-null CacheTag
instance.
- to produce a record reader in llapVectorizedOrcReaderForPath we either
know the tag or not depending the source of invocation
- - in case tag is known: we can do the metadata lookup and attach the
result to the OrcSplit
- - in case it's unknown: we create the split without the tail info, and let
OrcEncodedDataReader find out the metadata later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
