szlta commented on a change in pull request #2586:
URL: https://github.com/apache/hive/pull/2586#discussion_r700194971



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
##########
@@ -2693,6 +2696,77 @@ public static TypeDescription 
getDesiredRowTypeDescr(Configuration conf,
     return result;
   }
 
+  /**
+   * Based on the file schema and the low level file includes provided in the 
SchemaEvolution instance, this method
+   * calculates which top level columns should be included i.e. if any of the 
nested columns inside complex types is
+   * required, then its relevant top level parent column will be considered as 
required (and thus the full subtree).
+   * Hive and LLAP currently only supports column pruning on the first level, 
thus we need to calculate this ourselves.

Review comment:
       ACID is a special case, and I think it does. For ACID tables what Hive 
pushed down as projection is already a list of column indices within the row 
struct. So within this row struct for the first level columns, it should work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to