deniskuzZ commented on a change in pull request #2647: URL: https://github.com/apache/hive/pull/2647#discussion_r727789213
########## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/DummyTxnHandler.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore.txn; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.metastore.api.FindNextCompactRequest; +import org.apache.hadoop.hive.metastore.api.MetaException; + +import java.util.List; +import java.util.Optional; +import java.util.Set; + +public class DummyTxnHandler extends TxnHandler { Review comment: You could use Mockito.spy and mock the method that loads the TxnStore (i.e configured mock). ########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java ########## @@ -129,6 +130,22 @@ public static TxnStore getTxnStore(Configuration conf) { } } + /** + * Initialize static variables of TxnStore + * @param conf configuration + */ + public static void initializeTxnStore(Configuration conf) { + String className = MetastoreConf.getVar(conf, ConfVars.TXN_STORE_IMPL); + try { + Method init = JavaUtils.getClass(className, TxnStore.class) Review comment: You could fall back to the original approach and initialize it when used. btw not sure why we need multiple instances of TxnHandler, we don't keep state there, it's a service, can we define it as a singleton? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
