szehon-ho commented on a change in pull request #2647:
URL: https://github.com/apache/hive/pull/2647#discussion_r728461195
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java
##########
@@ -129,6 +130,22 @@ public static TxnStore getTxnStore(Configuration conf) {
}
}
+ /**
+ * Initialize static variables of TxnStore
+ * @param conf configuration
+ */
+ public static void initializeTxnStore(Configuration conf) {
+ String className = MetastoreConf.getVar(conf, ConfVars.TXN_STORE_IMPL);
+ try {
+ Method init = JavaUtils.getClass(className, TxnStore.class)
Review comment:
Yea I think that was the initial approach (initialize it when used), but
there was a comment that its better to fail the HMS startup if there are no
connections, rather than fail later. I guess the multiple instance of
TxnHandler has been there awhile, a bit before this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
