deniskuzZ commented on a change in pull request #3000:
URL: https://github.com/apache/hive/pull/3000#discussion_r800433132
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -433,6 +434,11 @@ private AcidDirectory getAcidDirectory(StorageDescriptor
sd, ValidWriteIdList wr
private CompactionType determineCompactionType(CompactionInfo ci,
AcidDirectory dir, Map<String,
String> tblproperties, long baseSize, long deltaSize) throws IOException
{
boolean noBase = false;
+
+ //Minor compaction is not possible for tables having raw format (non-acid)
data in them.
+ if (dir.getOriginalFiles().size() > 0 ||
dir.getCurrentDirectories().stream().anyMatch(AcidUtils.ParsedDelta::isRawFormat))
{
Review comment:
could we extract this check into an Initiator and Worker common parent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]