deniskuzZ commented on a change in pull request #3000:
URL: https://github.com/apache/hive/pull/3000#discussion_r803657571
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorThread.java
##########
@@ -137,6 +140,23 @@ protected Partition resolvePartition(CompactionInfo ci)
throws MetaException {
}
}
+ /**
+ * Check for that special case when minor compaction is not supported.
+ * <ul>
+ * <li>Query based Minor compaction is enabled</li>
+ * <li>The table is full acid</li>
+ * <li>The table has non-acid data either as original files or in any of
the delta directories.</li>
+ * </ul>
+ * @param tblproperties The properties of the table to check
+ * @param dir The {@link AcidDirectory} instance pointing to the table's
folder on the filesystem.
+ * @return Returns true if minor compaction is disabled based on the given
parameters, false otherwise.
+ */
+ protected boolean isMinorCompactionDisabled(Map<String, String>
tblproperties, AcidDirectory dir) {
Review comment:
can we rename it to 'isMinorCompactionSupported'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
