veghlaci05 commented on a change in pull request #3000:
URL: https://github.com/apache/hive/pull/3000#discussion_r803658762
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java
##########
@@ -69,16 +72,147 @@
import org.apache.tez.dag.history.logging.proto.ProtoMessageReader;
import org.junit.Assert;
import org.junit.Test;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mockito;
+import org.mockito.internal.util.reflection.FieldSetter;
+import static org.apache.hadoop.hive.ql.TxnCommandsBaseForTests.runWorker;
import static
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.execSelectAndDumpData;
import static
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.executeStatementOnDriver;
import static
org.apache.hadoop.hive.ql.txn.compactor.CompactorTestUtil.executeStatementOnDriverAndReturnResults;
-import static org.mockito.Mockito.doAnswer;
-import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.*;
@SuppressWarnings("deprecation")
public class TestCrudCompactorOnTez extends CompactorOnTezTest {
+ @Test
+ public void testMinorCompactionShouldBeRefusedOnTablesWithOriginalFiles()
throws Exception {
+ conf.setBoolVar(HiveConf.ConfVars.COMPACTOR_CRUD_QUERY_BASED, true);
+
+ final String dbName = "default";
+ final String tableName = "compaction_test";
+ executeStatementOnDriver("drop table if exists " + tableName, driver);
+ executeStatementOnDriver("CREATE TABLE " + tableName + "(id string, value
string) CLUSTERED BY(id) " +
+ "INTO 10 BUCKETS STORED AS ORC
TBLPROPERTIES('transactional'='false')", driver);
+
+ executeStatementOnDriver("INSERT INTO TABLE " + tableName + " values
('1','one'),('2','two'),('3','three')," +
+
"('4','four'),('5','five'),('6','six'),('7','seven'),('8','eight'),('9','nine'),('10','ten'),"
+
+
"('11','eleven'),('12','twelve'),('13','thirteen'),('14','fourteen'),('15','fifteen'),('16','sixteen'),"
+
+
"('17','seventeen'),('18','eighteen'),('19','nineteen'),('20','twenty')",
driver);
+
+ executeStatementOnDriver("alter table " + tableName + " set
TBLPROPERTIES('transactional'='true')", driver);
+
+ executeStatementOnDriver("insert into " + tableName + " values ('21',
'value21'),('84', 'value84')," +
+ "('66', 'value66'),('54', 'value54')", driver);
+ executeStatementOnDriver("insert into " + tableName + " values ('22',
'value22'),('34', 'value34')," +
+ "('35', 'value35')", driver);
+ executeStatementOnDriver("insert into " + tableName + " values ('75',
'value75'),('99', 'value99')", driver);
+
+ execSelectAndDumpData("select * from " + tableName, driver, "Dumping data
for " +
+ tableName + " after load:");
+
+ TxnStore txnHandler = TxnUtils.getTxnStore(conf);
+
+ //Prevent initiator from submitting the compaction requests
Review comment:
Because in case of initiator based compaction, it will simply submit
major compaction instead of minor, and that is already checked by the test. it
adds nothing to run the major compaction itself. By preventing the initiator to
submit the major compaction we can use the same table in the test to initiate a
manual minor compaction and check it fails with the right error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
