pvary commented on code in PR #3287: URL: https://github.com/apache/hive/pull/3287#discussion_r881416545
########## ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.parse; + +/** + * Execute operation specification. It stores the type of the operation and its parameters. + * The following operation are supported + * <ul> + * <li>Rollback</li> + * </ul> + * @param <T> Value object class to store the operation specific parameters + */ +public class AlterTableExecuteSpec<T> { + + public enum ExecuteOperationType { + ROLLBACK + } + + private final ExecuteOperationType operationType; + private final T operationParams; + + public AlterTableExecuteSpec(ExecuteOperationType type, T value) { + this.operationType = type; + this.operationParams = value; + } + + public ExecuteOperationType getOperationType() { + return operationType; + } + + public T getOperationParams() { + return operationParams; + } + + @Override + public String toString() { + return "operationType=" + operationType.name() + ", " + operationParams; + } + + /** + * Value object class, that stores the rollback operation specific parameters + * <ul> + * <li>Rollback type: it can be either version based or time based</li> + * <li>Rollback value: it should either a snapshot id or a timestamp in milliseconds</li> + * </ul> + */ + public static class RollbackSpec { + + public enum RollbackType { + VERSION, TIME + } + + private final RollbackType rollbackType; + private final Long param; + + public RollbackSpec(RollbackType rollbackType, Long param) { + this.rollbackType = rollbackType; + this.param = param; + } + + public RollbackType getRollbackType() { + return rollbackType; + } + + public Long getParam() { + return param; + } + + @Override + public String toString() { + return "rollbackType=" + rollbackType.name() + ", param=" + param; Review Comment: nit: We might want to use MoreObjects to generate the toString? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
