pvary commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r881410490
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergTimeTravel.java:
##########
@@ -20,31 +20,35 @@
package org.apache.iceberg.mr.hive;
import java.io.IOException;
-import java.text.SimpleDateFormat;
-import java.util.Date;
import java.util.List;
import org.apache.iceberg.AssertHelpers;
import org.apache.iceberg.HistoryEntry;
import org.apache.iceberg.Table;
import org.junit.Assert;
import org.junit.Test;
+import static
org.apache.iceberg.mr.hive.HiveIcebergTestUtils.timestampAfterSnapshot;
+
/**
* Tests covering the time travel feature, aka reading from a table as of a
certain snapshot.
*/
public class TestHiveIcebergTimeTravel extends
HiveIcebergStorageHandlerWithEngineBase {
@Test
public void testSelectAsOfTimestamp() throws IOException,
InterruptedException {
- Table table = prepareTableWithVersions(2);
+ Table table = testTables.createTableWithVersions(shell, "customers",
+ HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA,
+ fileFormat, HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS, 2);
List<Object[]> rows = shell.executeStatement(
- "SELECT * FROM customers FOR SYSTEM_TIME AS OF '" +
timestampAfterSnapshot(table, 0) + "'");
+ "SELECT * FROM customers FOR SYSTEM_TIME AS OF '" +
Review Comment:
What is the change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
