pvary commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r881411074


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java:
##########
@@ -379,4 +382,23 @@ public static DeleteFile createPositionalDeleteFile(Table 
table, String deleteFi
     return posWriter.toDeleteFile();
   }
 
+  /**
+   * Get the timestamp string which we can use in the queries. The timestamp 
will be after the given snapshot
+   * and before the next one
+   * @param table The table which we want to query
+   * @param snapshotPosition The position of the last snapshot we want to see 
in the query results
+   * @return The timestamp which we can use in the queries
+   */
+  public static String timestampAfterSnapshot(Table table, int 
snapshotPosition) {

Review Comment:
   Never mind, I see you just refactored this :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to