deniskuzZ commented on code in PR #3557:
URL: https://github.com/apache/hive/pull/3557#discussion_r973141236
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
##########
@@ -1011,96 +1015,61 @@ private Path constructRenamedPath(Path defaultNewPath,
Path currentPath) {
defaultNewPath.toUri().getPath());
}
- @VisibleForTesting
- public static List<ColumnStatistics>
alterTableUpdateTableColumnStats(RawStore msdb, Table oldTable, Table newTable,
- EnvironmentContext ec, String validWriteIds, Configuration conf,
List<String> deletedCols)
- throws MetaException, InvalidObjectException {
- String catName = normalizeIdentifier(oldTable.isSetCatName() ?
oldTable.getCatName() :
- getDefaultCatalog(conf));
+ public static List<ColumnStatistics> getColumnStats(RawStore msdb, Table
oldTable)
+ throws NoSuchObjectException, MetaException {
+ String catName = normalizeIdentifier(oldTable.isSetCatName()
+ ? oldTable.getCatName()
+ : getDefaultCatalog(msdb.getConf()));
String dbName = oldTable.getDbName().toLowerCase();
String tableName = normalizeIdentifier(oldTable.getTableName());
- String newDbName = newTable.getDbName().toLowerCase();
- String newTableName = normalizeIdentifier(newTable.getTableName());
- //if its not called from cahced store then update the table
- boolean doAlterTable = deletedCols == null;
- List<ColumnStatistics> newMultiColStats = new ArrayList<>();
+ return msdb.getTableColumnStatistics(catName, dbName, tableName,
Review Comment:
put into a variable
````
oldTable.getSd().getCols().stream().map(FieldSchema::getName).collect(Collectors.toList()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
