SourabhBadhya commented on code in PR #3557:
URL: https://github.com/apache/hive/pull/3557#discussion_r970940220


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
##########
@@ -235,6 +235,10 @@ public void alterTable(RawStore msdb, Warehouse wh, String 
catName, String dbnam
 
       boolean renamedTranslatedToExternalTable = rename && 
MetaStoreUtils.isTranslatedToExternalTable(oldt)
           && MetaStoreUtils.isTranslatedToExternalTable(newt);
+
+      List<ColumnStatistics> columnStatistics = getColumnStats(msdb, oldt);
+      columnStatistics = deleteTableColumnStats(msdb, oldt, newt, 
columnStatistics);

Review Comment:
   Since we have deleted the table column stats, do we need to call 
deleteAllPartitionColumnStatistics here?
   
[https://github.com/apache/hive/blob/f6bd0eb80767adfa9ce9f47a6d02a4940903effb/stand[…]ain/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java](https://github.com/apache/hive/blob/f6bd0eb80767adfa9ce9f47a6d02a4940903effb/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java#L417)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to