veghlaci05 commented on code in PR #3557:
URL: https://github.com/apache/hive/pull/3557#discussion_r973964881
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
##########
@@ -1112,6 +1081,32 @@ public static List<ColumnStatistics>
alterTableUpdateTableColumnStats(RawStore m
return newMultiColStats;
}
+ @VisibleForTesting
+ public static void updateTableColumnStats(RawStore msdb, Table newTable,
String validWriteIds, List<ColumnStatistics> columnStatistics)
Review Comment:
According to our offline conversation, I file a new Jira for creating a new
stats related utility class, and move all realted methods there. For now only
the static modifier is removed.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
##########
@@ -1011,96 +1015,61 @@ private Path constructRenamedPath(Path defaultNewPath,
Path currentPath) {
defaultNewPath.toUri().getPath());
}
- @VisibleForTesting
- public static List<ColumnStatistics>
alterTableUpdateTableColumnStats(RawStore msdb, Table oldTable, Table newTable,
- EnvironmentContext ec, String validWriteIds, Configuration conf,
List<String> deletedCols)
- throws MetaException, InvalidObjectException {
- String catName = normalizeIdentifier(oldTable.isSetCatName() ?
oldTable.getCatName() :
- getDefaultCatalog(conf));
+ public static List<ColumnStatistics> getColumnStats(RawStore msdb, Table
oldTable)
Review Comment:
According to our offline conversation, I file a new Jira for creating a new
stats related utility class, and move all realted methods there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
