deniskuzZ commented on code in PR #3935: URL: https://github.com/apache/hive/pull/3935#discussion_r1071104172
########## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorFactory.java: ########## @@ -99,10 +99,12 @@ public Compactor getCompactor(Table table, HiveConf configuration, CompactionInf case MINOR: return new MmMinorQueryCompactor(); case MAJOR: + case REBALANCE: + // REBALANCE COMPACTION on an insert-only table is simply a MAJOR compaction. Since there is no ACID row data, + // there is no acid row order to keep, and the number of buckets cannot be set at all (it will be calculated + // and created by TEZ dynamically). Initiator won't schedule REBALANCE compactions for insert-only tables, + // however users can request it. In these cases we simply fall back to MAJOR compaction return new MmMajorQueryCompactor(); - default: Review Comment: why remove this, what if the user mistypes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org