deniskuzZ commented on code in PR #3935:
URL: https://github.com/apache/hive/pull/3935#discussion_r1071107521
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -315,10 +315,14 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
return false;
}
- if (!ci.type.equals(CompactionType.REBALANCE) && ci.numberOfBuckets > 0)
{
- if (LOG.isWarnEnabled()) {
- LOG.warn("Only the REBALANCE compaction accepts the number of
buckets clause (CLUSTERED INTO {N} BUCKETS). " +
- "Since the compaction request is {}, it will be ignored.",
ci.type);
+ boolean insertOnly = AcidUtils.isInsertOnlyTable(table.getParameters());
+ if (LOG.isWarnEnabled() && ci.type.equals(CompactionType.REBALANCE) &&
insertOnly) {
+ LOG.warn("REBALANCE compaction requested on an insert-only table ({}).
Falling back to MAJOR compaction as " +
+ "REBALANCE compaction is supported only on full-acid tables",
table.getTableName());
+ if (ci.numberOfBuckets > 0) {
Review Comment:
check was previously for `!ci.type.equals(CompactionType.REBALANCE)`, now
it's inside `ci.type.equals(CompactionType.REBALANCE) && insertOnly`, is it
expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
