deniskuzZ commented on code in PR #3935: URL: https://github.com/apache/hive/pull/3935#discussion_r1072518934
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java: ########## @@ -342,15 +342,17 @@ public CompactionInfo findNextToCompact(FindNextCompactRequest rqst) throws Meta public void markCompacted(CompactionInfo info) throws MetaException { try { Connection dbConn = null; - Statement stmt = null; + PreparedStatement pstmt = null; Review Comment: use try-with-resources since you refactored this method, it's reported in findbugs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org