SourabhBadhya commented on code in PR #3959: URL: https://github.com/apache/hive/pull/3959#discussion_r1073148504
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: ########## @@ -67,6 +67,9 @@ public class MetastoreConf { static final String DEFAULT_STORAGE_SCHEMA_READER_CLASS = "org.apache.hadoop.hive.metastore.DefaultStorageSchemaReader"; @VisibleForTesting + static final String SERDE_STORAGE_SCHEMA_READER_CLASS = + "org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader"; Review Comment: Since you are introducing this, could you please add assertion case here - Check the below - https://github.com/apache/hive/blob/c92a478e514a28a53009fe5fbf08ce6fa35b58b9/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java#L482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org