saihemanth-cloudera commented on code in PR #3959:
URL: https://github.com/apache/hive/pull/3959#discussion_r1081666470
##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -30,6 +30,12 @@
<artifactId>hive-standalone-metastore-common</artifactId>
<version>4.0.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-metastore</artifactId>
Review Comment:
Why do you need to add this dependency? I don't think this is required.
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1363,7 +1366,7 @@ public enum ConfVars {
"hive.metastore.stats.auto.analyze.worker.count", 1,
"Number of parallel analyze commands to run for background stats
update."),
STORAGE_SCHEMA_READER_IMPL("metastore.storage.schema.reader.impl",
"metastore.storage.schema.reader.impl",
- DEFAULT_STORAGE_SCHEMA_READER_CLASS,
+ SERDE_STORAGE_SCHEMA_READER_CLASS,
Review Comment:
Does this work with other storage formats like ORC, parquet, and textfile? I
see that SERDE_STORAGE_SCHEMA_READER is compatible with Iceberg which is
awesome.
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java:
##########
@@ -482,6 +483,8 @@ public void dumpConfig() throws IOException {
public void testClassNames() {
Assert.assertEquals(MetastoreConf.DEFAULT_STORAGE_SCHEMA_READER_CLASS,
DefaultStorageSchemaReader.class.getName());
+ Assert.assertEquals(MetastoreConf.SERDE_STORAGE_SCHEMA_READER_CLASS,
Review Comment:
Can you add a unit test/q test with the failed test case? Also, it would be
nice to add other storage format options along with Avro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
