tarak271 commented on code in PR #3959:
URL: https://github.com/apache/hive/pull/3959#discussion_r1100380431


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1363,7 +1366,7 @@ public enum ConfVars {
         "hive.metastore.stats.auto.analyze.worker.count", 1,
         "Number of parallel analyze commands to run for background stats 
update."),
     STORAGE_SCHEMA_READER_IMPL("metastore.storage.schema.reader.impl", 
"metastore.storage.schema.reader.impl",
-        DEFAULT_STORAGE_SCHEMA_READER_CLASS,
+        SERDE_STORAGE_SCHEMA_READER_CLASS,

Review Comment:
   Code flow 
   
https://github.com/apache/hive/blob/cdf34923122c5bd6f3fda8153a3e53b9ff051d88/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L6300
   will not go through storage serde for formats listed at 
   
https://github.com/apache/hive/blob/cdf34923122c5bd6f3fda8153a3e53b9ff051d88/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java#L1304
   
   I have validated for Avro and storage handler type formats like HBase, JDBC



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to