mdayakar commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1201532676
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,25 @@ public ObjectInspector initialize(ObjectInspector[]
arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
Review Comment:
Now it requires minimum two arguments so validation can be changed. Also
second argument should be StringObjectInspector type so this check can also be
added.
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean
execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
What will happen if `getStoredProcedure(name.toUpperCase()) `returns null
(in case the function is not registered as a HPL/SQL function). I feel this
scenario is not handled, please check once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
