soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1219958089
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean
execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
From my understanding, if we don't use a procedure and use just a udf
instead, it will take a different code path, i.e., it won't use the hplsql udf.
But, I have added two tests to check that udfs work well in hplsql mode. Please
review again. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
