soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1213702972
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean
execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
I think this is handled in the beginning of the method,
[here](https://github.com/apache/hive/blob/7cd3107a76d633ef5fae2ffb8ec16953ac968092/hplsql/src/main/java/org/apache/hive/hplsql/Exec.java#L1849).
It ultimately calls [this
method](https://github.com/apache/hive/blob/7cd3107a76d633ef5fae2ffb8ec16953ac968092/hplsql/src/main/java/org/apache/hive/hplsql/functions/HmsFunctionRegistry.java#L148),
and checks that the function is present. Since they both are using the same
HMS API, I think this shouldn't be an issue, but let me know if we still need
to check something here. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
