ayushtkn commented on code in PR #4627:
URL: https://github.com/apache/hive/pull/4627#discussion_r1304165272
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -479,6 +479,8 @@ alterStatementSuffixExecute
-> ^(TOK_ALTERTABLE_EXECUTE KW_EXPIRE_SNAPSHOTS $expireParam)
| KW_EXECUTE KW_SET_CURRENT_SNAPSHOT LPAREN (snapshotParam=Number) RPAREN
-> ^(TOK_ALTERTABLE_EXECUTE KW_SET_CURRENT_SNAPSHOT $snapshotParam)
+ | KW_EXECUTE KW_FASTFORWARD sourceBranch=StringLiteral KW_TO
targetBranch=StringLiteral
+ -> ^(TOK_ALTERTABLE_EXECUTE KW_FASTFORWARD $sourceBranch $targetBranch)
Review Comment:
We have every function calls of iceberg under execute, rollback, set current
snapshot, expire snapshot. they also followed same syntax rather than having
alter table ice01 expire snapshot 10;
So, wanted to stay in the same area. And we have couple of more coming, so
they all can stay in same space
I will make the target branch as optional.
Regarding TO.
```
alter table ice01 fast-forward test1 to main;
```
Doesn't this not make more sense like we are fast forwarding the test1
branch to where the main branch is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
