zhangbutao commented on code in PR #4627:
URL: https://github.com/apache/hive/pull/4627#discussion_r1305379156
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -479,6 +479,8 @@ alterStatementSuffixExecute
-> ^(TOK_ALTERTABLE_EXECUTE KW_EXPIRE_SNAPSHOTS $expireParam)
| KW_EXECUTE KW_SET_CURRENT_SNAPSHOT LPAREN (snapshotParam=Number) RPAREN
-> ^(TOK_ALTERTABLE_EXECUTE KW_SET_CURRENT_SNAPSHOT $snapshotParam)
+ | KW_EXECUTE KW_FASTFORWARD sourceBranch=StringLiteral KW_TO
targetBranch=StringLiteral
+ -> ^(TOK_ALTERTABLE_EXECUTE KW_FASTFORWARD $sourceBranch $targetBranch)
Review Comment:
I see you. If we want to refer to git syntax, i am ok with this change.
I just thought `TO` keyword would make syntax more smoothly, but the thought
maybe a little subjectively.
Anyway, i am ok with or without `TO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
