zhangbutao commented on code in PR #4627:
URL: https://github.com/apache/hive/pull/4627#discussion_r1305187219
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -479,6 +479,8 @@ alterStatementSuffixExecute
-> ^(TOK_ALTERTABLE_EXECUTE KW_EXPIRE_SNAPSHOTS $expireParam)
| KW_EXECUTE KW_SET_CURRENT_SNAPSHOT LPAREN (snapshotParam=Number) RPAREN
-> ^(TOK_ALTERTABLE_EXECUTE KW_SET_CURRENT_SNAPSHOT $snapshotParam)
+ | KW_EXECUTE KW_FASTFORWARD sourceBranch=StringLiteral KW_TO
targetBranch=StringLiteral
+ -> ^(TOK_ALTERTABLE_EXECUTE KW_FASTFORWARD $sourceBranch $targetBranch)
Review Comment:
It feels a little strange omitting `KW_TO` keyword. IMO, I think it is more
reasonable to retain the `KW_TO` keyword.
Spark fast_fowrward procedure also has two syntax, one of is has `KW_TO`
keyword.
https://github.com/apache/iceberg/blob/1f8dbae31aab98654ebf4d64d37b04bff8eb22fd/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestFastForwardBranchProcedure.java#L123-L124
https://github.com/apache/iceberg/blob/master/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestFastForwardBranchProcedure.java#L81-L82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
