zhangbutao commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1348234097
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -826,7 +835,7 @@ public void testStatsAfterQueryCompactionOnTez() throws
Exception {
parameters = Hive.get().getTable(tblName).getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"1", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"2", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"735", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"736", parameters.get("totalSize"));
Review Comment:
I saw you have removed `totalSize ` in the UT of `TestCompactor.java`, so
should we remove this line as well?
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##########
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"1", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"4", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"704", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"705", parameters.get("totalSize"));
Review Comment:
I saw you have removed `totalSize `in the UT of `TestCompactor.java`, so
should we remove this line as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
