abstractdog commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1352666151


##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -108,8 +108,8 @@ private void 
testRebalanceCompactionWithParallelDeleteAsSecond(boolean optimisti
     conf.setBoolVar(HiveConf.ConfVars.TXN_WRITE_X_LOCK, optimisticLock);
 
     //set grouping size to have 3 buckets, and re-create driver with the new 
config
-    conf.set("tez.grouping.min-size", "1000");
-    conf.set("tez.grouping.max-size", "80000");
+    conf.set("tez.grouping.min-size", "400");

Review Comment:
   okay, in this case, I believe the comment should be edited to "set grouping 
size to have 4 buckets"
   how many buckets were used just by upgrading ORC?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to