abstractdog commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1352705834
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##########
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"1", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"4", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"704", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"705", parameters.get("totalSize"));
Review Comment:
we're removing some totalSize assertions but not others, let's simply keep
it consistent, choose 1 option now from the below ones:
1. remove all occurrences that have been changed here by the patch, so it's
visible now
2. remove only from qtests
3. remove all occurrences from the code -> time-consuming, I'm not
recommending this
4. don't remove any totalSize assertions
I believe only 1) makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
