simhadri-g commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1355699322
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3860,6 +3860,17 @@ public static enum ConfVars {
"is discouraged. It suffers from known bugs that are unlikely to be
fixed in subsequent versions of the product." +
"Furthermore, using SIMPLE formatter may lead to strange behavior, and
unexpected results when combined " +
"with SQL functions/operators that are using the new DATETIME
formatter."),
+
+ HIVE_DATETIME_RESOLVERSTYLE("hive.datetime.resolver.style", "SMART", new
StringSet("SMART", "STRICT", "LENIENT"),
Review Comment:
Done
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3860,6 +3860,17 @@ public static enum ConfVars {
"is discouraged. It suffers from known bugs that are unlikely to be
fixed in subsequent versions of the product." +
"Furthermore, using SIMPLE formatter may lead to strange behavior, and
unexpected results when combined " +
"with SQL functions/operators that are using the new DATETIME
formatter."),
+
+ HIVE_DATETIME_RESOLVERSTYLE("hive.datetime.resolver.style", "SMART", new
StringSet("SMART", "STRICT", "LENIENT"),
Review Comment:
> I think we should mention here that this property only takes effect when
the formatter is set to DATETIME.
Fixed
>Alternatively, we could also do some kind of mapping for SimpleDateFormat
but I don't think we want to add new functionality for a kind of deprecated
config unless someone ask us to do it.
I agree, SimpleDateFormatter has way too many inconsistencies its better to
push everyone to the DateTimeFormatter
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3860,6 +3860,17 @@ public static enum ConfVars {
"is discouraged. It suffers from known bugs that are unlikely to be
fixed in subsequent versions of the product." +
"Furthermore, using SIMPLE formatter may lead to strange behavior, and
unexpected results when combined " +
"with SQL functions/operators that are using the new DATETIME
formatter."),
+
+ HIVE_DATETIME_RESOLVERSTYLE("hive.datetime.resolver.style", "SMART", new
StringSet("SMART", "STRICT", "LENIENT"),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
