zabetak commented on code in PR #4777:
URL: https://github.com/apache/hive/pull/4777#discussion_r1360511958
##########
ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q:
##########
@@ -0,0 +1,20 @@
+DESCRIBE FUNCTION UNIX_TIMESTAMP;
Review Comment:
There is a small inconsistency in the fact that the new property controlling
the resolution style does not take effect when the there is no pattern argument.
```sql
set hive.datetime.formatter=DATETIME;
set hive.datetime.formatter.resolver.style=STRICT
set hive.datetime.formatter.resolver.style=SMART
set hive.datetime.formatter.resolver.style=LENIENT
select unix_timestamp('2001-02-31');
NULL
```
No matter the value of the resolver the result will always be `null` so this
could be considered a bug by some people. This is not a regression though, so I
guess we could deal with it in a follow-up ticket if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
