deniskuzZ commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1389639759
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -188,23 +163,23 @@ WHEN NOT MATCHED THEN INSERT VALUES (source.a2, source.b2)
switch (getWhenClauseOperation(whenClause).getType()) {
case HiveParser.TOK_INSERT:
numInsertClauses++;
- handleInsert(whenClause, rewrittenQueryStr, targetNameNode, onClause,
+ handleInsert(whenClause, mergeRewriter, targetNameNode, onClause,
Review Comment:
i think we need to extract the whole merge logic.
check Merge COW patch, I had to pass 3 extra params in every handle method +
create extra deleteCow that basically joins deletes from Update and Delete
branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
