deniskuzZ commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1391017072
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java:
##########
@@ -94,17 +96,11 @@ private static BaseSemanticAnalyzer getInternal(QueryState
queryState, ASTNode t
return new ColumnStatsSemanticAnalyzer(queryState);
case HiveParser.TOK_UPDATE_TABLE:
- if (HiveConf.getBoolVar(queryState.getConf(),
HiveConf.ConfVars.SPLIT_UPDATE)) {
- return new SplitUpdateSemanticAnalyzer(queryState);
- }
+ return new UpdateSemanticAnalyzer(queryState, new
UpdateRewriterFactory(queryState.getConf()));
case HiveParser.TOK_DELETE_FROM:
- return new UpdateDeleteSemanticAnalyzer(queryState);
+ return new DeleteSemanticAnalyzer(queryState, new
DeleteRewriterFactory(queryState.getConf()));
case HiveParser.TOK_MERGE:
- if (HiveConf.getBoolVar(queryState.getConf(),
HiveConf.ConfVars.SPLIT_UPDATE) ||
- HiveConf.getBoolVar(queryState.getConf(),
HiveConf.ConfVars.MERGE_SPLIT_UPDATE)) {
- return new SplitMergeSemanticAnalyzer(queryState);
- }
return new MergeSemanticAnalyzer(queryState);
Review Comment:
dup of pev comment. why don't we follow the same approach as for
Update/Delete -> pass or init in constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
