deniskuzZ commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1389641514
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -226,17 +201,26 @@ WHEN NOT MATCHED THEN INSERT VALUES (source.a2, source.b2)
throw new SemanticException(ErrorMsg.MERGE_PREDIACTE_REQUIRED,
ctx.getCmd());
}
- boolean validating = handleCardinalityViolation(rewrittenQueryStr,
targetNameNode, onClauseAsText, targetTable,
- numWhenMatchedDeleteClauses == 0 && numWhenMatchedUpdateClauses == 0,
columnAppender);
- ReparseResult rr = ParseUtils.parseRewrittenQuery(ctx, rewrittenQueryStr);
+ if (!conf.getBoolVar(HiveConf.ConfVars.MERGE_CARDINALITY_VIOLATION_CHECK))
{
Review Comment:
if that is false, i don't think we should invoke handleCardinalityViolation,
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
