deniskuzZ commented on code in PR #4566:
URL: https://github.com/apache/hive/pull/4566#discussion_r1418805576


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -264,7 +240,7 @@ public void cleanEmptyAbortedAndCommittedTxns() throws 
MetaException {
      * 2. never deletes the maximum txnId even if it is before the 
TXN_OPENTXN_TIMEOUT window
      */
     try {
-      long lowWaterMark = 
getOpenTxnTimeoutLowBoundaryTxnId(jdbcResource.getConnection());
+      long lowWaterMark = jdbcResource.execute(new 
OpenTxnTimeoutLowBoundaryTxnIdHandler(openTxnTimeOutMillis));

Review Comment:
   should this be a function? how is that different from 
GenerateCompactionQueueIdFunction?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to