veghlaci05 commented on code in PR #4566:
URL: https://github.com/apache/hive/pull/4566#discussion_r1418808055
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -193,10 +194,11 @@ public boolean isDeadlock(SQLException e) {
/**
* Is the given exception a table not found exception
- * @param e Exception
+ * @param ex Exception
* @return
*/
- public boolean isTableNotExistsError(SQLException e) {
+ public boolean isTableNotExistsError(Throwable ex) {
Review Comment:
The logic slightly changed: Now the method accepts any kind of exceptions
and finds an `SQLException` within the exception chain. If no `SQLException`
found an `IllegalArgumentException` is thrown. This makes the caller code
slightly less complex, as there is no need to find the `SQLException` if it's
not the top one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
