deniskuzZ commented on code in PR #4566:
URL: https://github.com/apache/hive/pull/4566#discussion_r1418812037
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -546,61 +518,28 @@ public long findMinOpenTxnIdForCleaner() throws
MetaException {
@RetrySemantics.Idempotent
@Deprecated
public long findMinTxnIdSeenOpen() {
- if (!useMinHistoryLevel || useMinHistoryWriteId) {
+ if (!TxnHandlingFeatures.useMinHistoryLevel() ||
TxnHandlingFeatures.useMinHistoryWriteId()) {
Review Comment:
````
TxnHandler.ConfVars
.useMinHistoryLevel()
. setUseMinHistoryLevel(boolean toggle)
.useMinHistoryWriteId()
````
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -546,61 +518,28 @@ public long findMinOpenTxnIdForCleaner() throws
MetaException {
@RetrySemantics.Idempotent
@Deprecated
public long findMinTxnIdSeenOpen() {
- if (!useMinHistoryLevel || useMinHistoryWriteId) {
+ if (!TxnHandlingFeatures.useMinHistoryLevel() ||
TxnHandlingFeatures.useMinHistoryWriteId()) {
Review Comment:
````
TxnHandler.ConfVars
.useMinHistoryLevel()
.setUseMinHistoryLevel(boolean toggle)
.useMinHistoryWriteId()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
