abstractdog commented on code in PR #4920:
URL: https://github.com/apache/hive/pull/4920#discussion_r1433804579


##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -38,10 +38,12 @@
         <description>A base for other temporary directories.</description>
     </property>
 
+    <!-- in LLAP mode hive.tez.container.size isn't used to actually determine 
container size, however while -->

Review Comment:
   good question, so in case of a testing llap driver (e.g. 
TestMiniLlapLocalCliDriver), where there is no classic llap deamons at all, 
this was what I saw...however, you're pointing out a new confusion, yeah, so if 
hive.tez.container.size is not inline with the independently sized LLAP 
deamons, then this is a discrepancy in available slot calculation...let me 
check this for a LLAP product, most probably Cloudera's CDW, and bring clarity 
here, at least in comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to