zhangbutao commented on code in PR #4920:
URL: https://github.com/apache/hive/pull/4920#discussion_r1433820913


##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -38,10 +38,12 @@
         <description>A base for other temporary directories.</description>
     </property>
 
+    <!-- in LLAP mode hive.tez.container.size isn't used to actually determine 
container size, however while -->

Review Comment:
   Intresting discussion. I want to learn something about llap too. :)
   IMHO, `hive.tez.container.size` has no effect LLAP task(exector) memory 
size. It seems that llap task size is decided by this code:
   
https://github.com/apache/hive/blob/36ce858163a19e29eafe4a8d3307191bc28fc175/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java#L164-L165



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to