abstractdog commented on code in PR #4920:
URL: https://github.com/apache/hive/pull/4920#discussion_r1433826994
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -38,10 +38,12 @@
<description>A base for other temporary directories.</description>
</property>
+ <!-- in LLAP mode hive.tez.container.size isn't used to actually determine
container size, however while -->
Review Comment:
yeah, hive.tez.container.size has no effect on the actual executor memory
size (that's handled on LLAP codepath, e,g, what you linked, part of llap
deamon sizing), but it seems to have an effect on available slots calculation,
which is a crucial part of the split generation, that's why I'll have to
clarify this area in code comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
