zhangbutao commented on code in PR #5024:
URL: https://github.com/apache/hive/pull/5024#discussion_r1475444666


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java:
##########
@@ -2057,4 +2057,26 @@ public void testSnycProperties() throws TException, 
InterruptedException {
   private String 
getCurrentSnapshotForHiveCatalogTable(org.apache.iceberg.Table icebergTable) {
     return ((BaseMetastoreTableOperations) ((BaseTable) 
icebergTable).operations()).currentMetadataLocation();
   }
+
+  @Test
+  public void testCreateTableWithPercentInName() throws TException, 
IOException, InterruptedException {

Review Comment:
   BTW, as this issue is only related hive catalog. you can add this code line:
   `Assume.assumeTrue("This test is only for hive catalog", testTableType == 
TestTables.TestTableType.HIVE_CATALOG);`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to