tthorpeIBM commented on code in PR #5024:
URL: https://github.com/apache/hive/pull/5024#discussion_r1499876358
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java:
##########
@@ -2057,4 +2057,32 @@ public void testSnycProperties() throws TException,
InterruptedException {
private String
getCurrentSnapshotForHiveCatalogTable(org.apache.iceberg.Table icebergTable) {
return ((BaseMetastoreTableOperations) ((BaseTable)
icebergTable).operations()).currentMetadataLocation();
}
+
+ @Test
+ public void testCreateTableWithPercentInName() throws IOException {
+ Assume.assumeTrue("This test requires Hive Version 4.",
HiveVersion.min(HiveVersion.HIVE_4));
Review Comment:
This check was needed on the Iceberg side to get the test to pass -
https://github.com/apache/iceberg/pull/9667
I included it here so the class was consistent across both but I've had
other issues with the formatting that required them to be different. I can
remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
