zhangbutao commented on PR #5024: URL: https://github.com/apache/hive/pull/5024#issuecomment-1922689068
> I added a test case in `TestHiveIcebergStorageHandlerNoScan` and ran: > > mvn package -Dtest="org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerNoScan" > > Test was successful. > > ``` > [INFO] Hive Iceberg Modules 4.0.0-beta-1 .................. SUCCESS [ 3.645 s] > [INFO] Patched Iceberg API patched-1.3.0-4.0.0-beta-1 ..... SUCCESS [ 1.161 s] > [INFO] Patched Iceberg Core patched-1.3.0-4.0.0-beta-1 .... SUCCESS [ 3.698 s] > [INFO] Hive Iceberg Shading 4.0.0-beta-1 .................. SUCCESS [ 9.430 s] > [INFO] Hive Iceberg Catalog 4.0.0-beta-1 .................. SUCCESS [08:46 min] > [INFO] Hive Iceberg Handler 4.0.0-beta-1 .................. SUCCESS [03:35 min] > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > ``` Thanks your test. Left two minor comments. Others lgtm. BTW, I think you can also submit a PR to Apache Iceberg repo, as this part code was backported from Apache Iceberg repo. https://github.com/apache/iceberg/blob/f8a4cc225db96a50088d2fb3693fa91f783d8f26/hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java#L133 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
