deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479596354
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##########
@@ -78,17 +81,13 @@ public void run() {
}
}
- private void cleanTheHouse() {
+ protected void cleanTheHouse() {
performTask(txnHandler::performTimeOuts, "Cleaning timed out txns and
locks");
performTask(txnHandler::performWriteSetGC, "Cleaning obsolete write set
entries");
performTask(txnHandler::cleanTxnToWriteIdTable, "Cleaning obsolete
TXN_TO_WRITE_ID entries");
- if (isCompactorEnabled) {
- performTask(txnHandler::removeDuplicateCompletedTxnComponents, "Cleaning
duplicate COMPLETED_TXN_COMPONENTS entries");
- performTask(txnHandler::purgeCompactionHistory, "Cleaning obsolete
compaction history entries");
- }
}
- private void performTask(FailableRunnable<MetaException> task, String
description) {
+ void performTask(FailableRunnable<MetaException> task, String description) {
long start = System.currentTimeMillis();
Functions.run(task);
Review Comment:
````
+import org.apache.commons.lang3.function.Failable;
+import org.apache.commons.lang3.function.FailableRunnable;
-import org.apache.commons.lang3.Functions;
replace Functions.run(task) with Failable.run(task)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
