deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479613805
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##########
@@ -78,17 +81,13 @@ public void run() {
}
}
- private void cleanTheHouse() {
+ protected void cleanTheHouse() {
performTask(txnHandler::performTimeOuts, "Cleaning timed out txns and
locks");
Review Comment:
could we refactor to
````
protected final Map<FailableRunnable<MetaException>, String> tasks;
````
in constructor:
````
public AcidHouseKeeperService() {
serviceName = this.getClass().getSimpleName();
tasks = ImmutableMap.<FailableRunnable<MetaException>, String>builder()
.put(txnHandler::performTimeOuts, "Cleaning timed out txns and locks")
.put(txnHandler::cleanTxnToWriteIdTable, "Cleaning obsolete
TXN_TO_WRITE_ID entries")
.build();
}
private void cleanTheHouse() {
tasks.forEach(this::performTask);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
