zhangbutao commented on code in PR #5063:
URL: https://github.com/apache/hive/pull/5063#discussion_r1528710963
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java:
##########
@@ -73,6 +73,9 @@ public static void beforeTest() throws Exception {
conf.setBoolVar(HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL, true);
conf.setBoolVar(HiveConf.ConfVars.DYNAMIC_PARTITIONING, true);
conf.setBoolVar(HiveConf.ConfVars.HIVE_CBO_ENABLED, false);
+ // Disable loading dynamic partitions from partition names in this test
+ // because get_partitions_by_names will also hit partition limit since
HIVE-28062.
+
conf.setBoolVar(HiveConf.ConfVars.HIVE_LOAD_DYNAMIC_PARTITIONS_SCAN_SPECIFIC_PARTITIONS,
false);
Review Comment:
`hive.load.dynamic.partitions.scan.specific.partitions` was inroduced by
HIVE-25178 to fetch only specific relevant **external** tables partitions by
partition names(using `getPartitionsByNames `method):
https://github.com/apache/hive/blob/ffb1165f59defa66b31b4fd9cb6367b71050071b/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3187-L3202
Here setting `hive.load.dynamic.partitions.scan.specific.partitions` to
false will give others a false impression that this propertity can be used to
control the partitions limit. However, It's just a coincidence as it just skip
to invoke `getPartitionsByNames `method when this propertity is false, and it
has nothing to do with partitions limit.
Am i right?
If it is ok, i would suggest to think another better to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
