deniskuzZ commented on code in PR #5063:
URL: https://github.com/apache/hive/pull/5063#discussion_r1530534014
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -1050,17 +1073,26 @@ private List<Partition>
getPartitionsFromPartitionIds(String catName, String dbN
+ ".\"SD_ID\" " + " left outer join " + SERDES + " on " + SDS +
".\"SERDE_ID\" = "
+ SERDES + ".\"SERDE_ID\" " + "where \"PART_ID\" in (" + partIds
+ ") order by \"PART_NAME\" asc";
+ // Keep order by name, consistent with JDO.
+ ArrayList<Partition> orderedResult = new
ArrayList<Partition>(partIdList.size());
+ populatePartitionsByQuery(catName, dbName, tblName, isView, queryText,
null, projectionFields,
+ isAcidTable, args, orderedResult);
+ return orderedResult;
+ }
+
+ private void populatePartitionsByQuery(String catName, String dbName, String
tblName,
Review Comment:
why not return `List<Partition> getPartitionsByQuery(..)` instead of passing
it as an input param?
PS: looks like there are unused params:
https://sonarcloud.io/project/issues?resolved=false&pullRequest=5063&id=apache_hive&open=AY19o4k2MYzl9k2s6F6V
please check sonar report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
