zhangbutao commented on code in PR #5063:
URL: https://github.com/apache/hive/pull/5063#discussion_r1529931142
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java:
##########
@@ -73,6 +73,9 @@ public static void beforeTest() throws Exception {
conf.setBoolVar(HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL, true);
conf.setBoolVar(HiveConf.ConfVars.DYNAMIC_PARTITIONING, true);
conf.setBoolVar(HiveConf.ConfVars.HIVE_CBO_ENABLED, false);
+ // Disable loading dynamic partitions from partition names in this test
+ // because get_partitions_by_names will also hit partition limit since
HIVE-28062.
+
conf.setBoolVar(HiveConf.ConfVars.HIVE_LOAD_DYNAMIC_PARTITIONS_SCAN_SPECIFIC_PARTITIONS,
false);
Review Comment:
I know it's just a workaround to fix the failed UT and not related to the
real cases. But IMO, `hive.load.dynamic.partitions.scan.specific.partitions`
should not be bound together with `getPartitionsByNames `, and we may can use
other methods like `getPartitionsBy...` to achieve this in future.
This part maks me little confusing, but this is just a small fix about the
UT, so i think it does't matter. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
