deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1532297215
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ########## @@ -462,7 +463,12 @@ private void commitTable(FileIO io, ExecutorService executor, OutputTable output .map(x -> x.getJobConf().get(ConfVars.REWRITE_POLICY.varname)) .orElse(RewritePolicy.DEFAULT.name())); - commitOverwrite(table, branchName, startTime, filesForCommit, rewritePolicy); + String partitionSpec = outputTable.jobContexts.stream() Review Comment: that should be a List here instead of mapping in commitOverwrite -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org