deniskuzZ commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1532302493
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1110,8 +1110,9 @@ public void validateSinkDesc(FileSinkDesc sinkDesc)
throws SemanticException {
// If the table is empty we don't have any danger that some data can
get lost.
return;
}
- if (RewritePolicy.fromString(conf.get(ConfVars.REWRITE_POLICY.varname,
RewritePolicy.DEFAULT.name())) ==
- RewritePolicy.ALL_PARTITIONS) {
+ RewritePolicy rewritePolicy =
RewritePolicy.fromString(conf.get(ConfVars.REWRITE_POLICY.varname,
+ RewritePolicy.DEFAULT.name()));
+ if (rewritePolicy == RewritePolicy.ALL_PARTITIONS || rewritePolicy ==
RewritePolicy.SINGLE_PARTITION) {
Review Comment:
do we need this check since we add support for partition-level IOW?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
